Fix missing output_schema argument in 'define_tool' API#301
Open
amorde wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Fix missing output_schema argument in 'define_tool' API#301amorde wants to merge 1 commit intomodelcontextprotocol:mainfrom
amorde wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
koic
reviewed
Apr 7, 2026
| Tool::Response.new({ "response" => message }) | ||
| end | ||
|
|
||
| stored_tool = @server.instance_variable_get(:@tools)["defined_tool"] |
Member
There was a problem hiding this comment.
Suggested change
| stored_tool = @server.instance_variable_get(:@tools)["defined_tool"] | |
| stored_tool = @server.tools["defined_tool"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing
output_schemakeyword argument toMCP::Server#define_toolMotivation and Context
Using the
define_toolAPI it's not currently possible to pass in theoutput_schemavalue.How Has This Been Tested?
Unit tested
Breaking Changes
N/A
Types of changes
Checklist
Additional context
N/A