Validate Content-Type on POST requests#304
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Validate Content-Type on POST requests#304koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
## Motivation and Context The MCP Streamable HTTP specification requires POST request bodies to be JSON-RPC messages with `Content-Type: application/json`. The Ruby SDK did not validate Content-Type, accepting requests with any or no Content-Type. The Python SDK validates this and returns 415 Unsupported Media Type for non-JSON Content-Types. ## How Has This Been Tested? Added tests for Content-Type validation: - POST without Content-Type returns 415 - POST with `Content-Type: text/plain` returns 415 - POST with `Content-Type: application/json; charset=utf-8` succeeds ## Breaking Changes POST requests without `Content-Type: application/json` now return 415 Unsupported Media Type. This is a spec compliance fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The MCP Streamable HTTP specification requires POST request bodies to be JSON-RPC messages with
Content-Type: application/json. The Ruby SDK did not validate Content-Type, accepting requests with any or no Content-Type. The Python SDK validates this and returns 415 Unsupported Media Type for non-JSON Content-Types.How Has This Been Tested?
Added tests for Content-Type validation:
Content-Type: text/plainreturns 415Content-Type: application/json; charset=utf-8succeedsBreaking Changes
POST requests without
Content-Type: application/jsonnow return 415 Unsupported Media Type. This is a spec compliance fix.Types of changes
Checklist