Auto-set server.transport in Transport#initialize#305
Open
koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Auto-set server.transport in Transport#initialize#305koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
server.transport in Transport#initialize#305koic wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
## Motivation and Context Transport subclasses (StreamableHTTPTransport, StdioTransport) already receive the server in their constructor, but users must manually call `server.transport = transport` after creating a transport instance. This is boilerplate that can be eliminated by setting the connection automatically in `Transport#initialize`. ## How Has This Been Tested? All existing tests pass. Redundant `server.transport = transport` lines were removed from tests, examples, README.md, and conformance server. ## Breaking Changes None. Existing code that manually sets `server.transport = transport` continues to work (idempotent assignment).
koic
force-pushed
the
auto_set_server_transport
branch
from
15979cb to
4f2d056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Transport subclasses (StreamableHTTPTransport, StdioTransport) already receive the server in their constructor, but users must manually call
server.transport = transportafter creating a transport instance. This is boilerplate that can be eliminated by setting the connection automatically inTransport#initialize.How Has This Been Tested?
All existing tests pass. Redundant
server.transport = transportlines were removed from tests, examples, README.md, and conformance server.Breaking Changes
None. Existing code that manually sets
server.transport = transportcontinues to work (idempotent assignment).Types of changes
Checklist