Skip to content

fix: prevent Linux paths from being converted to Windows drive paths #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xr843 wants to merge 1 commit into from
+141 −52
Closed

fix: prevent Linux paths from being converted to Windows drive paths #3642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
184 changes: 134 additions & 50 deletions src/filesystem/__tests__/path-utils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,18 +31,44 @@ describe('Path Utilities', () => {
}
});

it('leaves Windows paths unchanged but ensures backslashes', () => {
expect(convertToWindowsPath('C:\\NS\\MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
expect(convertToWindowsPath('C:/NS/MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
it('only converts standard Windows drive paths on Windows platform', () => {
if (process.platform === 'win32') {
expect(convertToWindowsPath('C:/NS/MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
} else {
// On Linux, C:/path should not have slashes converted
expect(convertToWindowsPath('C:/NS/MyKindleContent'))
.toBe('C:/NS/MyKindleContent');
}
});

it('leaves Windows paths unchanged but ensures backslashes on Windows', () => {
if (process.platform === 'win32') {
expect(convertToWindowsPath('C:\\NS\\MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
expect(convertToWindowsPath('C:/NS/MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
} else {
// On Linux, paths with drive letters are left as-is
expect(convertToWindowsPath('C:\\NS\\MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
expect(convertToWindowsPath('C:/NS/MyKindleContent'))
.toBe('C:/NS/MyKindleContent');
}
});

it('handles Windows paths with spaces', () => {
expect(convertToWindowsPath('C:\\Program Files\\Some App'))
.toBe('C:\\Program Files\\Some App');
expect(convertToWindowsPath('C:/Program Files/Some App'))
.toBe('C:\\Program Files\\Some App');
if (process.platform === 'win32') {
expect(convertToWindowsPath('C:\\Program Files\\Some App'))
.toBe('C:\\Program Files\\Some App');
expect(convertToWindowsPath('C:/Program Files/Some App'))
.toBe('C:\\Program Files\\Some App');
} else {
expect(convertToWindowsPath('C:\\Program Files\\Some App'))
.toBe('C:\\Program Files\\Some App');
expect(convertToWindowsPath('C:/Program Files/Some App'))
.toBe('C:/Program Files/Some App');
}
});

it('handles drive letter paths based on platform', () => {
Expand Down Expand Up @@ -79,18 +105,28 @@ describe('Path Utilities', () => {
});

it('removes surrounding quotes', () => {
expect(normalizePath('"C:\\NS\\My Kindle Content"'))
.toBe('C:\\NS\\My Kindle Content');
if (process.platform === 'win32') {
expect(normalizePath('"C:\\NS\\My Kindle Content"'))
.toBe('C:\\NS\\My Kindle Content');
} else {
// On Linux, drive-letter paths are not specially handled
const result = normalizePath('"C:\\NS\\My Kindle Content"');
expect(result).not.toContain('"');
}
});

it('normalizes backslashes', () => {
expect(normalizePath('C:\\\\NS\\\\MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
if (process.platform === 'win32') {
expect(normalizePath('C:\\\\NS\\\\MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
}
});

it('converts forward slashes to backslashes on Windows', () => {
expect(normalizePath('C:/NS/MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
if (process.platform === 'win32') {
expect(normalizePath('C:/NS/MyKindleContent'))
.toBe('C:\\NS\\MyKindleContent');
}
});

it('always preserves WSL paths (they work correctly in WSL)', () => {
Expand All @@ -115,17 +151,19 @@ describe('Path Utilities', () => {
});

it('handles paths with spaces and mixed slashes', () => {
expect(normalizePath('C:/NS/My Kindle Content'))
.toBe('C:\\NS\\My Kindle Content');
if (process.platform === 'win32') {
expect(normalizePath('C:/NS/My Kindle Content'))
.toBe('C:\\NS\\My Kindle Content');
expect(normalizePath('C:\\Program Files (x86)\\App Name'))
.toBe('C:\\Program Files (x86)\\App Name');
expect(normalizePath('"C:\\Program Files\\App Name"'))
.toBe('C:\\Program Files\\App Name');
expect(normalizePath(' C:\\Program Files\\App Name '))
.toBe('C:\\Program Files\\App Name');
}
// WSL paths should always be preserved
expect(normalizePath('/mnt/c/NS/My Kindle Content'))
.toBe('/mnt/c/NS/My Kindle Content');
expect(normalizePath('C:\\Program Files (x86)\\App Name'))
.toBe('C:\\Program Files (x86)\\App Name');
expect(normalizePath('"C:\\Program Files\\App Name"'))
.toBe('C:\\Program Files\\App Name');
expect(normalizePath(' C:\\Program Files\\App Name '))
.toBe('C:\\Program Files\\App Name');
});

it('preserves spaces in all path formats', () => {
Expand All @@ -137,54 +175,59 @@ describe('Path Utilities', () => {
// On Windows, Unix-style paths like /c/ should be converted
expect(normalizePath('/c/Program Files/App Name'))
.toBe('C:\\Program Files\\App Name');
expect(normalizePath('C:/Program Files/App Name'))
.toBe('C:\\Program Files\\App Name');
} else {
// On Linux, /c/ is just a regular Unix path
expect(normalizePath('/c/Program Files/App Name'))
.toBe('/c/Program Files/App Name');
}
expect(normalizePath('C:/Program Files/App Name'))
.toBe('C:\\Program Files\\App Name');
});

it('handles special characters in paths', () => {
// Test ampersand in path
expect(normalizePath('C:\\NS\\Sub&Folder'))
.toBe('C:\\NS\\Sub&Folder');
expect(normalizePath('C:/NS/Sub&Folder'))
.toBe('C:\\NS\\Sub&Folder');
if (process.platform === 'win32') {
// Test ampersand in path
expect(normalizePath('C:\\NS\\Sub&Folder'))
.toBe('C:\\NS\\Sub&Folder');
expect(normalizePath('C:/NS/Sub&Folder'))
.toBe('C:\\NS\\Sub&Folder');

// Test tilde in path (short names in Windows)
expect(normalizePath('C:\\NS\\MYKIND~1'))
.toBe('C:\\NS\\MYKIND~1');

// Test other special characters
expect(normalizePath('C:\\Path with #hash'))
.toBe('C:\\Path with #hash');
expect(normalizePath('C:\\Path with (parentheses)'))
.toBe('C:\\Path with (parentheses)');
expect(normalizePath('C:\\Path with [brackets]'))
.toBe('C:\\Path with [brackets]');
expect(normalizePath('C:\\Path with @at+plus$dollar%percent'))
.toBe('C:\\Path with @at+plus$dollar%percent');
}
// WSL paths should always be preserved
expect(normalizePath('/mnt/c/NS/Sub&Folder'))
.toBe('/mnt/c/NS/Sub&Folder');

// Test tilde in path (short names in Windows)
expect(normalizePath('C:\\NS\\MYKIND~1'))
.toBe('C:\\NS\\MYKIND~1');
// Unix paths with tildes should be preserved
expect(normalizePath('/Users/NEMANS~1/FOLDER~2/SUBFO~1/Public/P12PST~1'))
.toBe('/Users/NEMANS~1/FOLDER~2/SUBFO~1/Public/P12PST~1');

// Test other special characters
expect(normalizePath('C:\\Path with #hash'))
.toBe('C:\\Path with #hash');
expect(normalizePath('C:\\Path with (parentheses)'))
.toBe('C:\\Path with (parentheses)');
expect(normalizePath('C:\\Path with [brackets]'))
.toBe('C:\\Path with [brackets]');
expect(normalizePath('C:\\Path with @at+plus$dollar%percent'))
.toBe('C:\\Path with @at+plus$dollar%percent');
});

it('capitalizes lowercase drive letters for Windows paths', () => {
expect(normalizePath('c:/windows/system32'))
.toBe('C:\\windows\\system32');
// WSL paths should always be preserved
expect(normalizePath('/mnt/d/my/folder'))
.toBe('/mnt/d/my/folder');

if (process.platform === 'win32') {
expect(normalizePath('c:/windows/system32'))
.toBe('C:\\windows\\system32');
// On Windows, Unix-style paths should be converted and capitalized
expect(normalizePath('/e/another/folder'))
.toBe('E:\\another\\folder');
} else {
}
// WSL paths should always be preserved
expect(normalizePath('/mnt/d/my/folder'))
.toBe('/mnt/d/my/folder');

if (process.platform !== 'win32') {
// On Linux, /e/ is just a regular Unix path
expect(normalizePath('/e/another/folder'))
.toBe('/e/another/folder');
Expand Down Expand Up @@ -365,6 +408,47 @@ describe('Path Utilities', () => {
expect(normalizePath('d:')).toBe('D:\\');
});

it('should NOT convert Linux paths starting with a single letter directory (issue #3628)', () => {
// Mock Linux platform (Docker container)
Object.defineProperty(process, 'platform', {
value: 'linux',
writable: true,
configurable: true
});

// /h/username/data should NOT become H:\username\data
expect(normalizePath('/h/username/data'))
.toBe('/h/username/data');

// Other single-letter directories should also be preserved
expect(normalizePath('/a/some/path'))
.toBe('/a/some/path');
expect(normalizePath('/z/foo/bar'))
.toBe('/z/foo/bar');

// Also test convertToWindowsPath directly
expect(convertToWindowsPath('/h/username/data'))
.toBe('/h/username/data');
});

it('reproduces exact scenario from issue #3628 (Docker on Linux)', () => {
// Simulate running inside a Linux Docker container
Object.defineProperty(process, 'platform', {
value: 'linux',
writable: true,
configurable: true
});

// This is the exact path pattern from the issue
const inputPath = '/h/username/MCP_Development/data';
const result = normalizePath(inputPath);

// Should NOT convert to H:\username\MCP_Development\data
expect(result).toBe('/h/username/MCP_Development/data');
expect(result).not.toContain('H:');
expect(result).not.toContain('\\');
});

it('should handle relative path slash conversion based on platform', () => {
// This test verifies platform-specific behavior naturally without mocking
// On Windows: forward slashes converted to backslashes
Expand Down
9 changes: 7 additions & 2 deletions src/filesystem/path-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ export function convertToWindowsPath(p: string): string {
}

// Handle standard Windows paths, ensuring backslashes
if (p.match(/^[a-zA-Z]:/)) {
// Only convert on Windows to prevent false matches on Linux
// (e.g., paths that happen to start with a letter followed by colon)
if (p.match(/^[a-zA-Z]:/) && process.platform === 'win32') {
return p.replace(/\//g, '\\');
}

Expand Down Expand Up @@ -92,7 +94,10 @@ export function normalizePath(p: string): string {
}

// Handle Windows paths: convert slashes and ensure drive letter is capitalized
if (normalized.match(/^[a-zA-Z]:/)) {
// Only apply Windows-specific formatting on Windows platform to prevent
// Linux paths from being incorrectly treated as Windows drive paths
// (fixes issue #3628: /h/username/data being converted to H:\username\data)
if (normalized.match(/^[a-zA-Z]:/) && process.platform === 'win32') {
let result = normalized.replace(/\//g, '\\');
// Capitalize drive letter if present
if (/^[a-z]:/.test(result)) {
Expand Down
Loading