-
Notifications
You must be signed in to change notification settings - Fork 19
[Fix] Prevent client from importing ray via twinkle.server.common.serialize
#123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| # Copyright (c) ModelScope Contributors. All rights reserved. | ||
| import json | ||
| from numbers import Number | ||
| from peft import LoraConfig | ||
| from typing import Mapping | ||
|
|
||
| from twinkle.dataset import DatasetMeta | ||
|
|
||
| primitive_types = (str, Number, bool, bytes, type(None)) | ||
| container_types = (Mapping, list, tuple, set, frozenset) | ||
| basic_types = (*primitive_types, *container_types) | ||
|
|
||
|
|
||
| def _serialize_data_slice(data_slice): | ||
| if data_slice is None: | ||
| return None | ||
| if isinstance(data_slice, range): | ||
| return {'_slice_type_': 'range', 'start': data_slice.start, 'stop': data_slice.stop, 'step': data_slice.step} | ||
| if isinstance(data_slice, (list, tuple)): | ||
| return {'_slice_type_': 'list', 'values': list(data_slice)} | ||
| raise ValueError(f'Http mode does not support data_slice of type {type(data_slice).__name__}. ' | ||
| 'Supported types: range, list, tuple.') | ||
|
|
||
| def serialize_object(obj) -> str: | ||
Yunnglin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| if isinstance(obj, DatasetMeta): | ||
| data = obj.__dict__.copy() | ||
| data['data_slice'] = _serialize_data_slice(data.get('data_slice')) | ||
| data['_TWINKLE_TYPE_'] = 'DatasetMeta' | ||
| return json.dumps(data, ensure_ascii=False) | ||
| elif isinstance(obj, LoraConfig): | ||
| filtered_dict = { | ||
| _subkey: _subvalue | ||
| for _subkey, _subvalue in obj.__dict__.items() | ||
| if isinstance(_subvalue, basic_types) and not _subkey.startswith('_') | ||
| } | ||
| filtered_dict['_TWINKLE_TYPE_'] = 'LoraConfig' | ||
| return json.dumps(filtered_dict, ensure_ascii=False) | ||
| elif isinstance(obj, Mapping): | ||
| return json.dumps(obj, ensure_ascii=False) | ||
| elif isinstance(obj, basic_types): | ||
| return obj | ||
| else: | ||
| raise ValueError(f'Unsupported object: {obj}') | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.