feat(mfusg): add Transient IBOUND (TIB) package#2724
Open
reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
Open
feat(mfusg): add Transient IBOUND (TIB) package#2724reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
reneangermeyer wants to merge 1 commit intomodflowpy:developfrom
Conversation
Add MfUsgTib class for changing IBOUND and ICBUND values at any stress period in MODFLOW-USG. Supports six data categories (ib0, ib1, ibm1, icb0, icb1, icbm1) with U2DINT arrays and line-by-line records. Also fix pre-existing duplicate MfUsgGnc entry in mfusg __all__.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2724 +/- ##
===========================================
+ Coverage 55.5% 72.4% +16.9%
===========================================
Files 644 676 +32
Lines 124135 130920 +6785
===========================================
+ Hits 68947 94915 +25968
+ Misses 55188 36005 -19183
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TIB package allows changing IBOUND and ICBUND values at any stress period in MODFLOW-USG. Use cases include excavation/reclamation, well drilling/plugging, and transient prescribed head/concentration cells. FloPy currently has no TIB support.
Supports six data categories per stress period: ib0, ib1, ibm1 (IBOUND) and icb0, icb1, icbm1 (ICBUND). Node arrays (ib0/icb0) use U2DINT format via Util2d, while list records (ib1/ibm1/icb1/icbm1) support HEAD/AVHEAD and CONC/AVCONC keywords. As required by the TIB specification, all node numbers are global — for structured grids, model.dis.get_node() can be used to convert (layer, row, col) tuples.
Changes: