[WIP] Improved UX for switching modpack versions#5141
Closed
aervxa wants to merge 4 commits intomodrinth:mainfrom
Closed
[WIP] Improved UX for switching modpack versions#5141aervxa wants to merge 4 commits intomodrinth:mainfrom
aervxa wants to merge 4 commits intomodrinth:mainfrom
Conversation
Signed-off-by: z0 <aervxa@gmail.com>
fix for previous commit which added text to the buttons Signed-off-by: z0 <aervxa@gmail.com>
Contributor
Author
Member
|
Heyo, thanks for putting this together - appreciate it! Unfortunately though, we're going to close this PR as we've been working on a broader redesign of this flow internally in #5136, which covers the UX improvements you were aiming for. Here's a preview of what that looks like!
Thanks again, definitely let us know if you have any ideas of improvements on Discord, we'd be happy to hear it! |
Contributor
Author
|
That's def way better than what I was trying to achieve. Goodluck ✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Not tested yet
Probable problems:
.download-cell on the header cell influencing button with text
ExternalIcon is not be the best fit for navigating to modpack's version page (icon for "link" or "changelog"?)