Fix logic error preventing allowed iframe query parameters from being preserved #5295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a logic bug in the
iframesrcsanitizer where allowed query parameters (e.g.,start,end,id) were being incorrectly stripped.The Issue:
Previously,
newSearchParamswas initialized as an empty object. The filtering loop attempted todeletedisallowed keys from this already empty object, which had no effect. Consequently, the finalurl.searchwas always set to an empty string, removing all parameters.The Fix:
We now initialize
newSearchParamswith the existing parameters from the URL. This ensures that the.delete()operation correctly removes only the disallowed parameters while keeping the allowed ones.