Fix: E0716 temporary value dropped while borrowed#1122
Open
alien43 wants to merge 1 commit intomoghtech:mainfrom
Open
Fix: E0716 temporary value dropped while borrowed#1122alien43 wants to merge 1 commit intomoghtech:mainfrom
alien43 wants to merge 1 commit intomoghtech:mainfrom
Conversation
Updated the AlertData::Custom formatting logic to resolve a compiler error introduced in newer Rust versions (1.92+). The previous use of format_args! within an if/else block created temporary values that were dropped before they could be used by the outer format! macro.
3 tasks
Author
|
I am sorry, I have no idea as I have never written Rust in my life. I just
generated this fix with Gemini in order to get my server running and
decided to upstream it.
…On Fri, 13 Mar 2026 at 16:41, azban ***@***.***> wrote:
*azban* left a comment (moghtech/komodo#1122)
<#1122 (comment)>
Does it make sense to pin rust-version to avoid downstream breakages, like
in packaging?
—
Reply to this email directly, view it on GitHub
<#1122 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL3E5KHDCACL4YMTOLNMBD4QQ233AVCNFSM6AAAAACS4J2WLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DANJWGQ3DGOBRGY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Gotcha. I deleted that comment because I found out that pinning the version sets a minimum, rather than allowing to pin to a specific older version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the AlertData::Custom formatting logic to resolve a compiler error introduced in newer Rust versions (1.92+). The previous use of format_args! within an if/else block created temporary values that were dropped before they could be used by the outer format! macro.