Skip to content

fix missing nullish check when selecting stack#1287

Merged
mbecker20 merged 1 commit intomoghtech:2.1.0from
ericls:shen/fix-creating-terminal-for-stack-when-no-stack
Apr 1, 2026
Merged

fix missing nullish check when selecting stack#1287
mbecker20 merged 1 commit intomoghtech:2.1.0from
ericls:shen/fix-creating-terminal-for-stack-when-no-stack

Conversation

@ericls
Copy link
Copy Markdown
Contributor

@ericls ericls commented Mar 28, 2026

Ran into a crash when creating terminal when I select type "stack" while I have 0 stacks configured.

Page crashes with following error:
Screenshot 2026-03-27 at 23 33 31

Looked at the code and looks like a simple case of missing null check.

Side note: Should we enable frontend source map in the builds?

@mbecker20 mbecker20 changed the base branch from main to 2.1.0 April 1, 2026 20:52
Copy link
Copy Markdown
Member

@mbecker20 mbecker20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@mbecker20 mbecker20 merged commit f13eb9e into moghtech:2.1.0 Apr 1, 2026
2 checks passed
mbecker20 added a commit that referenced this pull request Apr 1, 2026
* fix swarm config content hidden

* 2.0.1-dev-1

* bump ts deps

* align swarm config links

* StackServiceRun command is actually optional

* fix swarm not included in read resource toml

* deploy 2.0.1-dev-2

* logger support disabling timestamps (eg if they are already provided by docker logs)

* full opacity tag color selector

* Add UpdateSwarmNode execution and convert several large repetive blocks to macro handling

* add node update functionality

* deploy 2.0.1-dev-3

* deploy 2.1.0-dev-1

* toml variable export sorted by name

* deploy 2.1.0-dev-2

* dont use detach=false because it can hang indefinitely on misconfigured stacks

* deploy 2.1.0-dev-3

* swarm stack deploy explicitly '--detach=true' to avoid future changes in behavior

* fmt

* UI: Stack config: Fix Add Env File button

* fix swarm error propogation, add server connection error hover message

* deploy 2.1.0-dev-4

* fix service rm (should be stack rm

* fix container ports not displaying when server address not available for link

* fix build registry custom org configuration

* github action: comment out cache step (leads to no space on device)

* fix missing nullish check when selecting stack (#1287)

* fix container selector null crash

* provider selector custom input label adheres to showLabel

* fix: show/hide button non-functional in stack, sync, and build info views (#1267)

Co-authored-by: twalts <t.mwalton@yahoo.com>

* swarm stack support env vars through shell source file method

* tweaks

* bump deps

* deploy 2.1.0-dev-5

* auto update should work with swarm

* deploy 2.1.0-dev-6

* 2.1.0

---------

Co-authored-by: Shen Li <dustet@gmail.com>
Co-authored-by: T <github@mail.taylor.media>
Co-authored-by: twalts <t.mwalton@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants