feat: upgrade electron to 41 and nodejs to 24 COMPASS-9852#7950
feat: upgrade electron to 41 and nodejs to 24 COMPASS-9852#7950
Conversation
| { | ||
| name: 'package-macos-x64', | ||
| display_name: 'Package MacOS Intel', | ||
| run_on: 'macos-13', |
There was a problem hiding this comment.
Maybe at least the package would be good to keep on 13 (unless we're really sure that we don't want to support it)
There was a problem hiding this comment.
Oh good catch, I was filtering for -gui in evergreen and didn't see the plain 13 hosts
There was a problem hiding this comment.
8f1d92d to
c86163b
Compare
|
Depends on: mongodb-js/interruptor#3 |
c86163b to
693acfa
Compare
There was a problem hiding this comment.
Pull request overview
Upgrades the desktop runtime/tooling stack by moving the repo forward to Electron 41 and Node.js 24, along with associated CI/build config adjustments to keep builds and packaged-app tests running on supported environments.
Changes:
- Bump Electron to
^41.1.1across the monorepo and update the dependency-update configuration to track Electron majors again. - Raise the repo Node.js engine requirement to
>=24.14.0and align asdf/Evergreen Node settings. - Update Evergreen packaged-app test build variants (macOS 11 → macOS 14) to reflect the new runtime/platform constraints.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| scripts/update-dependencies-config.js | Removes the Electron major pin so automated dependency updates can advance Electron majors. |
| packages/hadron-ipc/package.json | Updates Electron dependency to 41.x. |
| packages/hadron-build/package.json | Updates Electron dependency to 41.x. |
| packages/connection-storage/package.json | Updates Electron dependency to 41.x. |
| packages/compass/package.json | Updates Electron to 41.x and bumps a mongosh worker-thread dependency patch version. |
| packages/compass-utils/package.json | Updates Electron dependency to 41.x. |
| packages/compass-shell/package.json | Updates Electron to 41.x and bumps mongosh-related dependencies. |
| packages/compass-schema-validation/package.json | Updates Electron dependency to 41.x. |
| packages/compass-query-bar/package.json | Updates Electron dependency to 41.x. |
| packages/compass-indexes/package.json | Updates Electron dependency to 41.x. |
| packages/compass-import-export/package.json | Updates Electron dependency to 41.x. |
| packages/compass-find-in-page/package.json | Updates Electron dependency to 41.x. |
| packages/compass-explain-plan/package.json | Updates Electron dependency to 41.x. |
| packages/compass-electron-menu/package.json | Updates Electron dependency to 41.x. |
| packages/compass-e2e-tests/package.json | Updates Electron dependency to 41.x for e2e package. |
| packages/compass-crud/package.json | Updates Electron dependency to 41.x. |
| packages/atlas-service/package.json | Updates Electron dependency to 41.x. |
| package.json | Raises Node engine requirement to >=24.14.0. |
| package-lock.json | Lockfile refresh reflecting Electron 41, Node engine bump, and transitive updates. |
| configs/webpack-config-compass/package.json | Updates Electron and browserslist used by the webpack config package. |
| .tool-versions | Updates asdf Node.js version to 24.14.0. |
| .evergreen/functions.yml | Updates Evergreen Node.js version variable and minor whitespace cleanup. |
| .evergreen/buildvariants-and-tasks.yml | Moves packaged-app macOS variants from 11 to 14 and consolidates task naming. |
| .evergreen/buildvariants-and-tasks.in.yml | Template updates corresponding to the generated Evergreen config changes. |
| "engines": { | ||
| "node": ">=22.21.1", | ||
| "node": ">=24.14.0", | ||
| "npm": ">=10.2.4" | ||
| }, |
There was a problem hiding this comment.
The Node.js engine requirement was bumped to ">=24.14.0", but several GitHub Actions workflows still pin node-version: 22.21.1 (e.g. .github/workflows/authors-and-third-party-notices.yaml, bump-packages.yaml, publish-compass*.yaml, publish-packages.yaml, start-*.yml, test-installers.yml, update-dependencies.yaml). This mismatch will cause CI to run on an unsupported Node version and can lead to install/test failures once engine checks kick in. Please update those workflow node-version values (or centralize the version to avoid drift).
719c2c8 to
d2a1d0c
Compare
Description
Upgrading electron and Node.js. Testing CI for now. WIP
Checklist
Motivation and Context
Open Questions
Dependents
Types of changes