chore(e2e): consolidate prepare and stop logic inside compass class#7954
Merged
gribnoysup merged 4 commits intomainfrom Apr 17, 2026
Merged
chore(e2e): consolidate prepare and stop logic inside compass class#7954gribnoysup merged 4 commits intomainfrom
gribnoysup merged 4 commits intomainfrom
Conversation
gribnoysup
added
the
no-title-validation
gribnoysup
changed the title
lerouxb
approved these changes
Apr 8, 2026
Member
lerouxb
left a comment
lerouxb
left a comment
There was a problem hiding this comment.
Code looks fine. I admittedly didn't run this - I'm gonna trust CI :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small cleanup PR: want to make sure that the stop logic is all in one place and is as much shared between desktop and web as possible, same for prepare code. There's more stuff we can consolidate, I'm starting with some very obvious things