Skip to content

chore(compass-e2e-tests): ignore warning about expiresAfterSeconds being non-int COMPASS-10563#7970

Merged
gribnoysup merged 2 commits intomainfrom
COMPASS-10563
Apr 17, 2026
Merged

chore(compass-e2e-tests): ignore warning about expiresAfterSeconds being non-int COMPASS-10563#7970
gribnoysup merged 2 commits intomainfrom
COMPASS-10563

Conversation

@nbbeeken
Copy link
Copy Markdown
Collaborator

Description

This new warning doesn't seem worth failing on and I couldn't find a place where we'd pass in a non-int so it must be "stored on disk" as the server ticket mentions.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

Dependents

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Compass E2E test runner global fixtures to tolerate a new MongoDB server warning related to TTL index expireAfterSeconds being converted to an integer, preventing otherwise-successful test runs from failing due to this server-side warning.

Changes:

  • Allow server warning 12025301 for all started test servers during global setup.
  • Add inline context referencing SERVER-120253 to document why the warning is ignored.

Comment thread packages/compass-e2e-tests/helpers/test-runner-global-fixtures.ts Outdated
// expireAfterSeconds to integer in index specs. This is a server-side
// conversion that happens regardless of the BSON type sent by the client.
for (const checker of serverLogsCheckers) {
checker.allowWarning(12025301);
Copy link
Copy Markdown
Collaborator

@paula-stacho paula-stacho Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're confident this is due to the server issue, can we find out which versions have this issue and only ignore for those? the warning itself could be a valid signal for a client problem, so I wouldn't ignore it across the board if possible

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, I'm fairly confident but limiting to the right server version makes sense to me

@nbbeeken nbbeeken requested a review from paula-stacho April 16, 2026 20:33
@gribnoysup gribnoysup merged commit f87a62c into main Apr 17, 2026
25 of 29 checks passed
@gribnoysup gribnoysup deleted the COMPASS-10563 branch April 17, 2026 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants