feat(crud): group bulk actions in BULK dropdown COMPASS-10293#7976
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
feat(crud): group bulk actions in BULK dropdown COMPASS-10293#7976cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Replace standalone Update and Delete toolbar buttons with a single DropdownMenuButton wired to the same handlers. Tighten toolbar flex layout to reduce wrapping at typical widths. Remove unused menu components and update e2e selectors.
Contributor
Author
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket COMPASS-10293.
Author : @misbamongo
Description
Documents tab toolbar: replaced the separate Update and Delete buttons with a single BULK dropdown (
DropdownMenuButton) with menu items Bulk update documents and Bulk delete documents, calling the sameonUpdateButtonClicked/onDeleteButtonClickedhandlers as before (unchanged modals, queries, and permission gating).Toolbar row:
flexWrap: 'nowrap'andminWidth: 0on the main bar and left action group,flexShrink: 0on the right cluster, to reduce awkward wrapping at typical laptop widths.Removed the now-unused
update-data-menu.tsxanddelete-data-menu.tsxcomponents.Updated unit tests in
crud-toolbar.spec.tsxand e2e selectors/tests for bulk update/delete flows.Checklist
Motivation and Context
Types of changes