Skip to content

MONGOCRYPT-838 fix publish-packages tasks#1137

Merged
kevinAlbs merged 2 commits intomongodb:masterfrom
kevinAlbs:fix.M838
Mar 18, 2026
Merged

MONGOCRYPT-838 fix publish-packages tasks#1137
kevinAlbs merged 2 commits intomongodb:masterfrom
kevinAlbs:fix.M838

Conversation

@kevinAlbs
Copy link
Contributor

@kevinAlbs kevinAlbs commented Mar 18, 2026

Follow-up to #1126 to address failing publish-packages tests on the waterfall.

  • Add missing test in bash check
  • Restore permissions: public-read and visibility: public when uploading to mciuploads
    • I expect using permissions: private prevents curator from downloading development packages.
    • permissions: private is only needed to upload to the restricted CDN bucket. The CDN bucket has a separate public download link.

There is no need to upload to mciuploads with private permissions. This prevents curator from accessing the mciuploads upload.
Copy link
Contributor

@vector-of-bool vector-of-bool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinAlbs kevinAlbs marked this pull request as ready for review March 18, 2026 17:13
@kevinAlbs kevinAlbs requested a review from a team as a code owner March 18, 2026 17:13
@kevinAlbs kevinAlbs requested a review from connorsmacd March 18, 2026 17:13
@kevinAlbs kevinAlbs merged commit acecff7 into mongodb:master Mar 18, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants