Skip to content

PYTHON-5528 - Token buckets disabled by default#2713

Merged
NoahStapp merged 5 commits intomongodb:backpressurefrom
NoahStapp:PYTHON-5528-token-bucket-refactor
Feb 26, 2026
Merged

PYTHON-5528 - Token buckets disabled by default#2713
NoahStapp merged 5 commits intomongodb:backpressurefrom
NoahStapp:PYTHON-5528-token-bucket-refactor

Conversation

@NoahStapp
Copy link
Contributor

PYTHON-5528

Changes in this PR

Python implementation of the most recent revision of DRIVERS-3239.

Test Plan

Added two new prose tests specified in the spec as well as a new unit test verifying the correct MongoClient configuration behavior for adaptiveRetries.

Checklist

Checklist for Author

  • Did you update the changelog (if necessary)?
  • Is there test coverage?
  • Is any followup work tracked in a JIRA ticket? If so, add link(s).

Checklist for Reviewer

  • Does the title of the PR reference a JIRA Ticket?
  • Do you fully understand the implementation? (Would you be comfortable explaining how this code works to someone else?)
  • Is all relevant documentation (README or docstring) updated?

@NoahStapp NoahStapp requested a review from a team as a code owner February 23, 2026 20:50
@NoahStapp NoahStapp requested review from Jibola and removed request for a team February 23, 2026 20:50
@NoahStapp NoahStapp changed the title PYTHON-5528 - Token buckets are opt-in only PYTHON-5528 - Token buckets disabled by default Feb 23, 2026
Copy link
Contributor

@sleepyStick sleepyStick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changes look good to me, at a glance, not sure why encryption tests are failing,,

@NoahStapp
Copy link
Contributor Author

your changes look good to me, at a glance, not sure why encryption tests are failing,,

They're fixed in master but not in the backpressure branch.

NoahStapp and others added 2 commits February 24, 2026 08:14
Co-authored-by: Sergey Zelenov <mail@zelenov.su>
Co-authored-by: Sergey Zelenov <mail@zelenov.su>
@NoahStapp
Copy link
Contributor Author

NoahStapp commented Feb 25, 2026

The encryption test failures are due to DRIVERS-3382 and are skipped in master until the bug is fixed.


.. seealso:: The MongoDB documentation on `connections <https://dochub.mongodb.org/core/connections>`_.

.. versionchanged:: 4.XX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is XX intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this will be our next major release I'll go ahead and update it now to 4.17.

@NoahStapp NoahStapp merged commit e7a5247 into mongodb:backpressure Feb 26, 2026
71 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants