TOOLS-4127 Add 8.3 support to test matrix#907
Merged
mmcclimon merged 7 commits intomongodb:masterfrom Mar 20, 2026
Merged
Conversation
mmcclimon
force-pushed
the
preliminary-8.3-support
branch
4 times, most recently
from
3133035 to
2857d88
Compare
mmcclimon
force-pushed
the
preliminary-8.3-support
branch
from
2857d88 to
d25b4fd
Compare
Collaborator
Author
|
(I'm going to hold off on this until rc0 is published) |
I don't know why this has changed, but it has!
This was removed as dead code in 8.3.
This was removed in SERVER-109560.
See SERVER-116018; 8.3 drops support for some arcane bit of Windows 2019, so we need to migrate to a newer distro.
mmcclimon
force-pushed
the
preliminary-8.3-support
branch
from
d25b4fd to
e1baa62
Compare
autarch
approved these changes
Mar 20, 2026
| var __origRawMongoProgramOutput = rawMongoProgramOutput; | ||
| rawMongoProgramOutput = function() { return __origRawMongoProgramOutput('.*') }; | ||
|
|
||
| ToolTest.prototype.runTool = function () { |
Collaborator
There was a problem hiding this comment.
I know it's in the PR description but I think a comment explaining the presence of this func would be helpful too.
Collaborator
Author
There was a problem hiding this comment.
Legit; added, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts testing the tools against a pre-release 8.3 version. There are a few minor changes here to support this: the most notable is that we need a version of
ToolTest.runToolin the library shim, because it was removed from the server testing code. The only other load-bearing change here is that thedisableTransitionFromLatestToLastContinuousparameter was removed in 8.3, so we now need to set that conditionally.Notably absent from this commit are any additional testing for server 8.3 features, or the line that publishes 8.3 support to the linux package repos. Those will come in later commits, but this code passes all the existing tests, so we might as well get it in to prepare for the upcoming work.