fix(ipa): relax itemsPerPage validation to require default > 1 for IPA-110#1186
Draft
fix(ipa): relax itemsPerPage validation to require default > 1 for IPA-110#1186
Conversation
Instead of enforcing an exact default of 100, the rule now accepts any default value greater than 1, allowing APIs to define their own reasonable page sizes. Co-Authored-By: Claude Code <noreply@anthropic.com>
andmatei
changed the title
Replace the mixed number|{min} parameter type with a consistent
object shape: { value: N } for exact match, { min: N } for range check.
Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xgen-IPA-110-collections-request-has-itemsPerPage-query-paramrule to accept anyitemsPerPagedefault value greater than 1, instead of requiring exactly 100checkPaginationQueryParameterAndReturnErrorsto support a{ min: N }constraint in addition to the existing exact-value check (preservingpageNumbehaviour)Jira: CLOUDP-330703
Test plan
pageNumstill pass (exact-value check unchanged)default: 2,default: 50default: 0,default: 1Generated with Claude Code