impr: enable dots typed effect for ligature languages (@byseif21)#7458
Merged
Miodec merged 20 commits intomonkeytypegame:masterfrom Feb 28, 2026
Merged
impr: enable dots typed effect for ligature languages (@byseif21)#7458Miodec merged 20 commits intomonkeytypegame:masterfrom
Miodec merged 20 commits intomonkeytypegame:masterfrom
Conversation
byseif21
force-pushed
the
fix/dots-effect
branch
from
ca7aca3 to
e051784
Compare
github-actions
Bot
added
the
waiting for review
byseif21
force-pushed
the
fix/dots-effect
branch
2 times, most recently
from
ded97b2 to
fb8df2e
Compare
Leonabcd123
reviewed
Jan 28, 2026
byseif21
force-pushed
the
fix/dots-effect
branch
from
fb8df2e to
aae08c9
Compare
Leonabcd123
reviewed
Jan 28, 2026
Leonabcd123
reviewed
Jan 28, 2026
| "colorfulMode", | ||
| "showAllLines", | ||
| "fontSize", | ||
| "fontFamily", |
Contributor
There was a problem hiding this comment.
We now run updateWordWrapperClasses unnecessarily when a user changes fontFamily.
Contributor
Author
There was a problem hiding this comment.
the thing is I think I still need some of the layout updates it triggers when fontFamily changes. I’ll give it some manual testing to see
Contributor
There was a problem hiding this comment.
Can we do this?
if (key !== "fontFamily"){
updateWordWrapperClasses();
}
Ligatures.update(key, wordsEl);
Contributor
Author
There was a problem hiding this comment.
kinda feel like fontFamily should also trigger updateWordWrapperClasses but can’t really prove it visually enough till now, so yeah ok I’ll leave it limited for now
byseif21
commented
Jan 28, 2026
| if (shouldReset) { | ||
| words.forEach(reset); | ||
| } | ||
| words.forEach(applyIfNeeded); |
Contributor
Author
There was a problem hiding this comment.
check if ok? or heavy and should we do batching instead?
Contributor
There was a problem hiding this comment.
I'd do this:
words.forEach((word) => {
if (shouldReset) reset(word);
applyIfNeeded(word);
})
(not tested)
Contributor
Author
There was a problem hiding this comment.
i meant performance wise
Contributor
There was a problem hiding this comment.
Performance wise we're running on the words twice when shouldReset is true, while we can do it one pass. I don't see why go with this approach rather than doing it in one loop.
Contributor
Author
There was a problem hiding this comment.
what do you think about batching then? too much or worth it?
Contributor
There was a problem hiding this comment.
I'd say it's worth it.
Leonabcd123
reviewed
Jan 28, 2026
Leonabcd123
reviewed
Jan 28, 2026
inline-flex/forced nowrap caused overflow when dots appeared, e.g very long words in Custom mode - so small hack for that, we detect actual multi-line wrapping by comparing per-letter top positions; lock width only for single-line words to stabilize dot spacing, and needs-wrap for multi-line words to preserve natural wrapping
github-actions
Bot
removed
the
waiting for review
github-actions
Bot
added
the
waiting for review
Miodec
added
the
waiting for update
github-actions
Bot
removed
the
waiting for update
IliyaZinoviev
pushed a commit
to IliyaZinoviev/monkeytype
that referenced
this pull request
Apr 24, 2026
…nkeytypegame#7458) fix the limitation of dots effect wouldn't work correctly for ligature-based languages cuz connected letters cannot be rendered as individual dots. before it was not worth the fix for the theme only now after the new typed effect feat monkeytypegame#7360 i think this needed. * introduces a small helper that breaks ligatures only after a word is finished, allowing the dots effect to render correctly while keeping ligatures intact during typing. * runs only when needed (on word completion or when the typed effect is switched to dots) and avoids any continuous checks or performance overhead. related monkeytypegame#6472
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the limitation of dots effect wouldn't work correctly for ligature-based languages cuz connected letters cannot be rendered as individual dots.
before it was not worth the fix for the theme only now after the new typed effect feat #7360 i think this needed.
introduces a small helper that breaks ligatures only after a word is finished, allowing the dots effect to render correctly while keeping ligatures intact during typing.
runs only when needed (on word completion or when the typed effect is switched to dots) and avoids any continuous checks or performance overhead.
related #6472