fix(funbox): apply space balls perspective only to test words (@d1rshan)#7803
Open
d1rshan wants to merge 1 commit intomonkeytypegame:masterfrom
Open
fix(funbox): apply space balls perspective only to test words (@d1rshan)#7803d1rshan wants to merge 1 commit intomonkeytypegame:masterfrom
d1rshan wants to merge 1 commit intomonkeytypegame:masterfrom
Conversation
monkeytypegeorge
added
frontend
github-actions
bot
added
the
waiting for review
d1rshan
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Restricts the “Space Balls” funbox 3D perspective/tilt effect to the typing words area on the test page to avoid impacting other UI/layout elements.
Changes:
- Scope
perspectiveto.pageTest #typingTestinstead of allmain. - Move the X-tilt transform from
.pageto#wordsWrapper(words UI container) and adjust tilt angle/origin.
d1rshan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR restricts the Space Balls 3D perspective effect only to the words ui to prevent layout issues with other test elements.
Current Behavior:
Now:
ik this changes the original intention for this effect, so understandable if this is not what you guys want but i have tried multiple different options and i think this is probably the cleanest fix for this.