fix: highlight search quote button when active (@byseif21)#7807
Open
byseif21 wants to merge 3 commits intomonkeytypegame:masterfrom
Open
fix: highlight search quote button when active (@byseif21)#7807byseif21 wants to merge 3 commits intomonkeytypegame:masterfrom
byseif21 wants to merge 3 commits intomonkeytypegame:masterfrom
Conversation
github-actions
bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Improves UX around Quote Search mode by visually indicating when Quote Search is the currently active quote-length setting (i.e., quoteLength === [-2]), helping users understand why quotes may not rotate normally after a test.
Changes:
- Desktop test config: highlight the Quote Search (magnifier) button when
quoteLengthis[-2]. - Mobile test config: treat Quote Search (
-2) as an “active” quote length option whenquoteLengthis[-2].
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/ts/components/pages/test/TestConfig.tsx | Adds active state to Quote Search button based on quoteLength === [-2]. |
| frontend/src/ts/components/modals/MobileTestConfigModal.tsx | Fixes Quote Search option active-state detection to reflect quoteLength === [-2]. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7796