Fixing a memory leak

[Jaders77]

This part of the code makes a copy of the original reference without calling the destructor at any time for it (original reference).
Instead of using a default constructor / copy constructor and then one destructor for each, such C++ copy elision optimization, it's better to simply remove copy.

Simple example of the problem:

public global::Lldb.SBSymbolContext GetSymbolContext(uint resolve_scope)
{
  var __ret = new global::Lldb.SBSymbolContext.__Internal();
  __Internal.GetSymbolContext((__Instance + __PointerAdjustment), new IntPtr(&__ret), resolve_scope); // here __ret is initialized like a constructor
  return global::Lldb.SBSymbolContext.__CreateInstance(__ret);
}

internal static global::Lldb.SBSymbolContext __CreateInstance(global::Lldb.SBSymbolContext.__Internal native, bool skipVTables = false)
{
  return new global::Lldb.SBSymbolContext(native, skipVTables);
}

private SBSymbolContext(global::Lldb.SBSymbolContext.__Internal native, bool skipVTables = false)
  : this(__CopyValue(native), skipVTables)
{
  __ownsNativeInstance = true;
  NativeToManagedMap[__Instance] = this;
}

private static void* __CopyValue(global::Lldb.SBSymbolContext.__Internal native)
{
  var ret = Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));
  global::Lldb.SBSymbolContext.__Internal.cctor(ret, new global::System.IntPtr(&native));
  return ret.ToPointer();
}

After the fix:

private static void* __CopyValue(global::Lldb.SBSymbolContext.__Internal native)
{
  var ret = Marshal.AllocHGlobal(sizeof(global::Lldb.SBSymbolContext.__Internal));
  *(global::Lldb.SBSymbolContext.__Internal*) ret = native;
  return ret.ToPointer();
}

[dnfclas]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Jaders77 sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[ddobrev]

The generated code now does not call the non-trivial constructor if any. I think this might lead to incorrect behaviours on the native side.