Open
Conversation
|
|
Contributor
|
Our CI fails with this PR. Could you please get at least the OS you use working? |
added 2 commits
September 14, 2021 13:34
- In IgnoreSystemDeclarationsPass: Explicitly renamed basic_string:: assign and data methods becasue otherwise some following implicit renamings make the code not working (this issue can be observer when a std::string and std::wstring is present in the C++ input classes) - Removed the resetting of method names in SpecializationMethodsWithDependentPointersPass becasue this reverts changes which are made in the pass IgnoreSystemDeclarationsPass - added wstring type map - added a hacky flag be able to run tests when the option MarshalCharAsManagedChar is set to false
- Adjusted TypeMap for wstring in Stdlib.CLI.cs - Fixed typo in Common.Test.cs - Added check in test - Added wstring exports in Std-symbols.cpp
strentler
force-pushed
the
wstring_support
branch
from
b2c1c01 to
f1743e9
Compare
Contributor
Author
|
Got it now partly threw your CI. MacOS is missing. To make this PR clean, there is still some work to do. |
Contributor
|
@strentler thank you very much for this piece, it's extremely important. Forget about macOS, I can take care of that part. I hope I'll be done by the time you've sent your cleansing. |
ddobrev
force-pushed
the
main
branch
3 times, most recently
from
bcf41e4 to
851ec5e
Compare
ddobrev
force-pushed
the
main
branch
5 times, most recently
from
97610ec to
a2aeaed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assign and data
methods becasue otherwise some following implicit renamings
make the code not working
(this issue can be observer when a std::string and std::wstring
is present in the C++ input classes)
SpecializationMethodsWithDependentPointersPass becasue
this reverts changes which are made in the pass
IgnoreSystemDeclarationsPass
option MarshalCharAsManagedChar is
set to false