Added support for wchar_t and std::wstring for C# by zillemarco · Pull Request #983 · mono/CppSharp

zillemarco · 2017-10-12T08:40:29Z

With the help of @tritao:

added support for wchar_t
added support for std::wstring
unified the way wide character strings are handled between C# and
C++/CLI
changed the way strings are handled, using 'IntPtr' instead of 'string'
with marshalling attributes on the P/Invokes

ddobrev · 2017-10-12T18:22:38Z

src/Runtime/Helpers.cs

            return encoding.GetString(buffer);
        }
+
+        public static IntPtr StringToHGlobalMultiByteUni(string str)


This isn't used anywhere.

ddobrev · 2017-10-12T18:24:14Z

src/Generator/Passes/CheckAbiParameters.cs

            // Deleting destructors (default in v-table) accept an i32 bitfield as a
            // second parameter in MS ABI.
-            if (method != null && method.IsDestructor && Context.ParserOptions.IsMicrosoftAbi)
+            var @class = method != null ? method.Namespace as Class : null;


Needlessly complicated - if the method is not null, then its name-space is always a class, just cast it.

ddobrev · 2017-10-12T18:25:06Z

src/Generator/Types/Std/Stdlib.cs

+            var type = ctx.Parameter.Type.Desugar();
+            ClassTemplateSpecialization basicString = GetBasicString(type);
+
+            if(basicString.Arguments[0].Type.Type.IsPrimitiveType(PrimitiveType.Char))


A space after the conditional operator.

ddobrev · 2017-10-12T18:26:25Z

src/Runtime/WideChar.cs

+    // Struct added to help map a the wchar_t C++ type to C#
+    // The data is stored as a 64 bit value so it could represent
+    // an UTF-32 character but C# only represents UTF-16 characters
+    // so beware of possible data loss when using it.


Not sure what this means, is it that our binding for wstring does not always work properly?

Just that C# char (UTF-16) type cannot represent the entirety of Unicode (UTF-32).

We should then think about throwing an exception if out of range.

I don't get this comment. wchar_t on Windows is represented as UTF16-LE. On Linux it's UTF-32. Char in C# is always UTF16-LE afaik. There is one more type to consider: char16_t is always UTF16-LE, regardless of the platform that's being used. (Since C++17). C++20 will also define UTF8 type char8_t.

phraemer · 2020-09-04T14:28:23Z

Has this been abandoned? Seems like it would be a nice improvement!

zillemarco · 2020-09-04T14:52:01Z

Frankly I have to really apologize for leaving this behind. I had other priorities at work so I couldn't give it the final push it needed.

I think I could be able to get back at this in my free time since not far from now I'll also need this at work.
If @tritao or @ddobrev could give me a little refresh on what was missing and/or what should be done I can give it a try.
Sorry but it's been almost 3 years and things most likely could have changed that impacted the work I did in this PR too.

tritao · 2020-09-04T15:30:43Z

I don't recall anymore either, but think it was pretty much good to go.

Please rebase it on top of latest master, make sure all tests still pass and lets take it from there.

@tritao

With the help of @tritao: - added support for wchar_t - added support for std::wstring - unified the way wide character strings are handled between C# and C++/CLI - changed the way strings are handled, using 'IntPtr' instead of 'string' with marshalling attributes on the P/Invokes

dnfadmin · 2020-09-05T06:39:32Z

All CLA requirements met.

tritao · 2020-09-05T10:47:43Z

It's not compiling anymore:

Passes\IgnoreSystemDeclarationsPass.cs(60,49): error CS0103: The name 'GetCharSpecializations' does not exist in the current context [C:\projects\cppsharp\src\Generator\CppSharp.Generator.csproj]

Guess some code moved around or was renamed, and needs to be updated in this PR.

zillemarco · 2020-09-05T11:00:14Z

Yeah I know, during the rebase I had quite a bit of conflicts. I was thinking about drafting the PR until I get it back to work.

zillemarco force-pushed the master branch from db2e796 to 19bfe5a Compare October 12, 2017 09:04

ddobrev suggested changes Oct 12, 2017

View reviewed changes

ddobrev force-pushed the master branch 3 times, most recently from d0c8e15 to 5ca9345 Compare October 25, 2017 22:08

ddobrev force-pushed the master branch 4 times, most recently from 4dfd9cc to e53b253 Compare November 21, 2017 01:07

ddobrev force-pushed the master branch from a242bc8 to 08bebbb Compare December 24, 2017 23:58

ddobrev force-pushed the master branch 12 times, most recently from 0464938 to 637018f Compare October 15, 2018 05:15

ddobrev force-pushed the master branch 4 times, most recently from 91e219c to 32da859 Compare January 4, 2019 21:27

ddobrev force-pushed the master branch from 1108e72 to e203463 Compare January 15, 2019 23:50

ddobrev force-pushed the master branch from 3164a89 to bc7f20a Compare February 14, 2019 17:28

tritao force-pushed the master branch 2 times, most recently from a0169c2 to 3ea7e97 Compare March 11, 2019 00:30

ddobrev force-pushed the master branch from 418c720 to 2acbf32 Compare May 29, 2020 23:22

zillemarco force-pushed the master branch from 19bfe5a to f8b4762 Compare September 5, 2020 06:39

zillemarco marked this pull request as draft September 14, 2020 15:16

ddobrev force-pushed the master branch from 46bdcd3 to 6acaf24 Compare November 24, 2020 21:36

tritao mentioned this pull request Dec 2, 2020

Marshalling char16_t* or wchar_t* #1538

Open

josetr force-pushed the master branch from 6cefae8 to c0a5d86 Compare December 10, 2020 01:12

ddobrev force-pushed the master branch 2 times, most recently from c930b78 to c38556a Compare January 2, 2021 20:41

Base automatically changed from master to main March 12, 2021 10:52

strentler mentioned this pull request Jul 23, 2021

UserManual.md says std::wstring is supported, but this is not ture #1620

Closed

ddobrev force-pushed the main branch 7 times, most recently from 4c1e9b8 to 2fdd082 Compare August 30, 2021 11:25

ddobrev force-pushed the main branch from 2f170dc to 50feab0 Compare September 18, 2021 20:30

ddobrev force-pushed the main branch 3 times, most recently from bcf41e4 to 851ec5e Compare October 2, 2021 15:17

ddobrev force-pushed the main branch 2 times, most recently from 8f64166 to 12f456e Compare October 27, 2021 22:32

Conversation

zillemarco commented Oct 12, 2017

Uh oh!

ddobrev Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

ddobrev Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

ddobrev Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

ddobrev Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

tritao Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

ddobrev Oct 12, 2017

Choose a reason for hiding this comment

Uh oh!

atlaste Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

phraemer commented Sep 4, 2020

Uh oh!

zillemarco commented Sep 4, 2020

Uh oh!

tritao commented Sep 4, 2020

Uh oh!

dnfadmin commented Sep 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tritao commented Sep 5, 2020

Uh oh!

zillemarco commented Sep 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dnfadmin commented Sep 5, 2020 •

edited

Loading