This repository was archived by the owner on Oct 4, 2021. It is now read-only.
Updating Light and Dark themes to match Visual Studio#9563
Closed
jmatthiesen wants to merge 5 commits intomasterfrom
Closed
Updating Light and Dark themes to match Visual Studio#9563jmatthiesen wants to merge 5 commits intomasterfrom
jmatthiesen wants to merge 5 commits intomasterfrom
Conversation
Member
|
@jmatthiesen is it intentional that you also added Light+/Dark+ files but did not add them to the csproj? |
Contributor
Author
Nope, good catch @sandyarmstrong - I just removed these. |
JoeRobich
reviewed
Jan 28, 2020
| { "name": "Keyword(Operator)", "fore": "keyword-blue" }, | ||
| { "name": "Keyword(Selection)", "fore": "keyword-blue" }, | ||
| { "name": "Keyword(Iteration)", "fore": "keyword-blue" }, | ||
| { "name": "Keyword(Jump)", "fore": "keyword-blue" }, |
Contributor
There was a problem hiding this comment.
If you decide to take #9606, you should update both the Light and Dark themes so that Keyword(Jump) is keyword-purple.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes VSTS #1052169
With this update: