[RELOPS-2269] Fix remove_old_hg triggering on puppet-managed symlink#1110
Open
rcurranmoz wants to merge 3 commits intomasterfrom
Open
[RELOPS-2269] Fix remove_old_hg triggering on puppet-managed symlink#1110rcurranmoz wants to merge 3 commits intomasterfrom
rcurranmoz wants to merge 3 commits intomasterfrom
Conversation
The onlyif 'test -f' check matched the /usr/local/bin/hg symlink created by the File resource, causing puppet to delete and recreate it on every apply. Narrow the check to regular files only so the exec only fires when the old hg binary (not a symlink) is present. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rcurranmoz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onlyif 'test -f' check matched the /usr/local/bin/hg symlink created by the File resource, causing puppet to delete and recreate it on every apply. Narrow the check to regular files only so the exec only fires when the old hg binary (not a symlink) is present.