Bug 2018783 - Clean up nimbus MetricsHandler rust bindings#7240
Merged
freshstrangemusic merged 1 commit intomainfrom Feb 24, 2026
Merged
Bug 2018783 - Clean up nimbus MetricsHandler rust bindings#7240freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
Member
Author
|
This PR is blocked on #7239 |
324c6e6 to
905aaeb
Compare
relud
reviewed
Feb 23, 2026
There are stateful and non-stateful metrics definitions in metrics.rs. This patch cleans up the MetricsHandler to keep the two scenarios more separate.
905aaeb to
04892a5
Compare
relud
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are stateful and non-stateful metrics definitions in metrics.rs. This patch cleans up the MetricsHandler to keep the two scenarios more separate.
Pull Request checklist
[ci full]to the PR title.