Skip to content

Comments

Bug 2018783 - Clean up nimbus MetricsHandler rust bindings#7240

Merged
freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic/push-uuqnmmvzrtuw
Feb 24, 2026
Merged

Bug 2018783 - Clean up nimbus MetricsHandler rust bindings#7240
freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic/push-uuqnmmvzrtuw

Conversation

@freshstrangemusic
Copy link
Member

There are stateful and non-stateful metrics definitions in metrics.rs. This patch cleans up the MetricsHandler to keep the two scenarios more separate.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@freshstrangemusic
Copy link
Member Author

This PR is blocked on #7239

Base automatically changed from freshstrangemusic/push-uxxopzmknnuu to main February 23, 2026 22:50
There are stateful and non-stateful metrics definitions in metrics.rs.
This patch cleans up the MetricsHandler to keep the two scenarios more
separate.
Merged via the queue into main with commit 7fb99ed Feb 24, 2026
13 checks passed
@freshstrangemusic freshstrangemusic deleted the freshstrangemusic/push-uuqnmmvzrtuw branch February 24, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants