feat: add ContentAnalysis/MaxConnectionsCount#61
Open
bsmth wants to merge 1 commit intomozilla:mainfrom
Open
Conversation
bsmth
changed the title
mkaply
requested changes
Feb 23, 2026
Contributor
mkaply
left a comment
mkaply
left a comment
There was a problem hiding this comment.
I'm not sure what we should use for arbitrary numbers.
0x is hex,. so that isn't right I think
| Software\Policies\Mozilla\Firefox\ContentAnalysis\InterceptionPoints\FileUpload\Enabled = 0x1 | 0x0 | ||
| Software\Policies\Mozilla\Firefox\ContentAnalysis\InterceptionPoints\Print\Enabled = 0x1 | 0x0 | ||
| Software\Policies\Mozilla\Firefox\ContentAnalysis\IsPerUser = 0x1 | 0x0 | ||
| Software\Policies\Mozilla\Firefox\ContentAnalysis\MaxConnectionsCount = 0x0 | 0x1 | 0x2 |
Contributor
There was a problem hiding this comment.
This isn't right because it can be an arbitrary number.
| - The `Print` entry controls print operation. | ||
| - `Enabled` indicates whether print operations should use DLP. The default is true. | ||
| - `IsPerUser` indicates whether the pipe the DLP agent has created is per-user or per-system. The default is true, meaning per-user. | ||
| - `MaxConnectionsCount`: The maximum number of concurrent connections to the DLP agent. For stability reasons, values exceeding 256 will be ignored. Defaults to `3`. |
Contributor
There was a problem hiding this comment.
I'm checking with the DLP team on the language.
Contributor
|
DLP team likes it, but default value should be 32, not 3. Let's just use 32 everywhere instead of 0x0 | 0x1 | 0x2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adding ContentAnalysis/MaxConnectionsCount
Motivation:
MaxConnectionsCount is missing from the ContentAnalysis page
Related issues and pull requests:
Fixes #58
See also: