Skip to content

bug(auth): Address case where sender is empty, null, or missing#20183

Open
dschom wants to merge 1 commit intomainfrom
FXA-12956.2
Open

bug(auth): Address case where sender is empty, null, or missing#20183
dschom wants to merge 1 commit intomainfrom
FXA-12956.2

Conversation

@dschom
Copy link
Contributor

@dschom dschom commented Mar 13, 2026

Because

  • We were seeing response validation errors in sentry
  • The sender should be optional

This pull request

  • Removes sender from response if empty, null, or undefined.

Issue that this pull request solves

Closes: FXA-12956

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

This state is a little bit bizarre. Typically the device id, which ends up being the sender value stored in the DB, is typically present on the DB write...

@dschom dschom requested a review from a team as a code owner March 13, 2026 00:17
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failures have been fixed on main, should be fixed after rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants