Conversation
…3x SVGs This commit: * Adds an 'illustrationsTheme' global property in Strapi to set colors used by our SVGs, with defaults if not supplied * Applies the theme to email code, backup codes, and authentication code SVGs, everywhere used * Adds Storybook documentation for each new image and theme property closes FXA-13256
LZoog
commented
Mar 17, 2026
| <FallingConfettiImage /> | ||
| export const ConfettiFallingFullPage = () => <FallingConfettiImage />; | ||
|
|
||
| const smartWindowTheme: IllustrationsTheme = { |
Contributor
Author
There was a problem hiding this comment.
I am open to other names here, but it was hard to pick them since they apply across these SVGs.
I'll send these color themes to Product to add onto the smart window entrypoints.
The UX person I worked with, Michelle, has approved!! I sent her screenshots.
vbudhram
approved these changes
Mar 18, 2026
| type="warning" | ||
| content={{ | ||
| localizedHeading: | ||
| 'Only solid colors are supported. CSS gradients cannot currently be used because they require an XML change inside the SVG.', |
Contributor
There was a problem hiding this comment.
Should we have a regex in Strapi or here to make sure only valid colors are used?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit:
closes FXA-13256
Strapi PR: mozilla/fxa-strapi/pull/193
This should not have CSP issues because this just uses CSS variables and
fill, not inline<style>tags.Check out stories for smart window theme / a nicer looking theme with clouds on the code.
Behold my ugly creation hooked up to strapi: