Open
Conversation
eemeli
requested changes
May 29, 2023
Member
eemeli
left a comment
eemeli
left a comment
There was a problem hiding this comment.
Rather than changing the behaviour of npm run lint, it'd be better to change the command used in CI to directly call npx eslint without the --fix argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the
linttarget is called with the--fixparameter, the CI wouldn't fail if there were autofixable issues. Split the fix vs lint targets, and reused Prettiers ignore file instead of creating a.eslintignorefile