Color aggregate lines the same across versions#631
Closed
jonco3 wants to merge 4 commits intomozilla:gh-pagesfrom
Closed
Color aggregate lines the same across versions#631jonco3 wants to merge 4 commits intomozilla:gh-pagesfrom
jonco3 wants to merge 4 commits intomozilla:gh-pagesfrom
Conversation
Contributor
|
I do indeed believe that this is #625 We might not wish to do this for the submission date view, as the same submission date can have multiple versions (the same x value can have multiple data points) for a single aggregate. See, for instance this. How bad would it look in the code if we only turned to this mode for submission date view? |
chutten
requested changes
Nov 26, 2019
Contributor
chutten
left a comment
chutten
left a comment
There was a problem hiding this comment.
Let me know what you think about my earlier comment.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present it can be confusing looking at evolution graphs because the individual aggregates get assigned different line colors for different versions, e.g.:
I'm not sure whether that's exactly what this issue is talking about but it may be: #625
These changes fix this by removing the version component from Line.getStateString and renaming it to Line.getColorId (this is the only use of that method).