refactor: modernize meson build to use dependency() and override_dependency()#6
Open
refactor: modernize meson build to use dependency() and override_dependency()#6
Conversation
…ndency()
Switch zipper and quiver consumption from subproject().get_variable() to
dependency() with [provide] sections in wrap files. Add
meson.override_dependency() calls for balsaCore, balsaGeometry, and
balsaVisualization so downstream projects can consume them via
dependency(). Fix colormap_shaders.wrap to use variable-based provide
instead of dependency_names. Guard quiver_dep in visualization with
get_option('quiver') check. Remove dead options (eltopo, pngpp, igl).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
meson.override_dependency()calls forbalsaCore,balsaGeometry, andbalsaVisualizationso downstream projects can consume balsa viadependency('balsaCore')etc.subproject().get_variable()todependency()with[provide]sections in wrap filescolormap_shaders.wrapto use variable-based[provide](colormap_shaders = colormap_shaders_dep) instead ofdependency_nameswhich requiresmeson.override_dependency()quiver_depinvisualization/meson.buildwithif get_option('quiver')to fix a bug where it was added unconditionallyeltopo,pngpp,igl) frommeson_options.txtthat were never referenced in any meson.buildPart of the cross-project meson modernization effort (zipper PR #12, cpp-template PR #1, quiver PR #7).
Testing
All 8 tests pass. Build produces 215 targets successfully.