Added Exists Method & Re-activating Stopped Intervals#3
Open
AndrewDavid wants to merge 4 commits intomtrpcic:masterfrom
Open
Added Exists Method & Re-activating Stopped Intervals#3AndrewDavid wants to merge 4 commits intomtrpcic:masterfrom
AndrewDavid wants to merge 4 commits intomtrpcic:masterfrom
Conversation
+ ‘exists’ method ^ stop method now uses exists method before attempting to stop interval ^ changed objects on line 18 & 19 to use dot notation
+ you can re-activate a previously created interval ^ exists method also checks whether interval is active
^ properly minified poll.min.js
|
+1 for this |
1 similar comment
|
+1 for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Version 0.3
existsmethod to check if a specific interval is already defined and optionally checks if it is currently stoppedactiveelement. This indicates whether the interval is currently stoppedstartmethod to allow re-activating a previously stopped interval:Poll.start('name');Here is a fiddle that demonstrates the feature: http://jsfiddle.net/AndrewDavidJ/ZzJ8R/