Skip to content

🔒 Replace unsafe innerHTML assignments with textContent in options.js #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmuench wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −7
Open

🔒 Replace unsafe innerHTML assignments with textContent in options.js #37

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions options/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,9 @@ const loadWebhooks = async () => {
const normalizedWebhooks = webhooks.map(normalizeWebhookRecord);
const list = document.getElementById("webhook-list");
const message = document.getElementById("no-webhooks-message");
list.innerHTML = "";

// Clear the webhook list safely
while (list.firstChild) {
list.removeChild(list.firstChild);
}
// Clear the webhook list safely using textContent
list.textContent = "";

// Populate group dropdown safely
const groupSelect = document.getElementById("webhook-group");
Expand Down Expand Up @@ -203,7 +200,7 @@ const loadGroups = async () => {
// Function to render groups in the group management modal
const renderGroups = async () => {
const groups = await loadGroups();
groupsList.innerHTML = "";
groupsList.textContent = "";

groups.forEach(group => {
const listItem = document.createElement("li");
Expand Down Expand Up @@ -684,7 +681,7 @@ customPayloadInput.addEventListener('input', function(e) {

if (matchingVars.length > 0) {
// Show autocomplete dropdown
variablesAutocomplete.innerHTML = '';
variablesAutocomplete.textContent = '';
variablesAutocomplete.classList.remove('hidden');

matchingVars.forEach(variable => {
Expand Down
Loading