Skip to content

[code-infra] Allow more permissive Element types #48186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JCQuintas wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[code-infra] Allow more permissive Element types #48186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages-internal/api-docs-builder/utils/getPropsFromComponentNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@ function isTypeJSXElementLike(type: ts.Type, project: TypeScriptProject): boolea
if (symbol) {
const name = project.checker.getFullyQualifiedName(symbol);
return (
// Remove once global JSX namespace is no longer used by React
name === 'global.JSX.Element' ||
name === 'React.JSX.Element' ||
name === 'React.ReactElement' ||
name === 'React.ReactNode'
// Some types are resolved to paths like: "/Users/.../node_modules/@types/react/jsx-runtime".JSX.Element
name.endsWith('.JSX.Element') || name.endsWith('.ReactElement') || name.endsWith('.ReactNode')
);
}

Expand Down
7 changes: 2 additions & 5 deletions packages-internal/docs-utils/src/getPropsFromComponentNode.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,8 @@ function isTypeJSXElementLike(type: ts.Type, project: TypeScriptProject): boolea
if (symbol) {
const name = project.checker.getFullyQualifiedName(symbol);
return (
// Remove once global JSX namespace is no longer used by React
name === 'global.JSX.Element' ||
name === 'React.JSX.Element' ||
name === 'React.ReactElement' ||
name === 'React.ReactNode'
// Some types are resolved to paths like: "/Users/.../node_modules/@types/react/jsx-runtime".JSX.Element
name.endsWith('.JSX.Element') || name.endsWith('.ReactElement') || name.endsWith('.ReactNode')
);
}

Expand Down
Loading