[internal] Update some host-reference entries#48225
[internal] Update some host-reference entries#48225silviuaavram wants to merge 3 commits intomui:v7.xfrom
Conversation
Netlify deploy previewhttps://deploy-preview-48225--material-ui.netlify.app/ Bundle size report
|
There was a problem hiding this comment.
Pull request overview
This internal PR updates hardcoded documentation host URLs to point to the v7 docs domain and annotates those references with #host-reference markers to make them easier to locate/manage across the repo.
Changes:
- Updated the docs host in
buildColorTypesoutput to usehttps://v7.mui.com/. - Switched several inline “learn more”/API documentation links from
https://mui.comtohttps://v7.mui.com. - Added
// #host-referencemarkers near these hardcoded host references.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/buildColorTypes.js | Updates the HOST used for generated color preview JSDoc image links to v7.mui.com and marks it as a host reference. |
| packages/mui-utils/src/elementTypeAcceptingRef/elementTypeAcceptingRef.ts | Updates the “caveat with refs” help link to v7.mui.com and adds a host-reference marker. |
| packages/mui-system/src/ThemeProvider/ThemeProvider.d.ts | Updates the ThemeProvider API doc link to v7.mui.com and adds a host-reference marker. |
| packages/mui-system/src/cssVars/createCssVarsProvider.js | Updates the dev-only guidance link to v7.mui.com and adds a host-reference marker. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| warningHint = 'Did you accidentally provide a React.Fragment instead?'; | ||
| } | ||
|
|
||
| // #host-reference |
There was a problem hiding this comment.
The // #host-reference comment is not indented even though it sits inside elementTypeAcceptingRef. This breaks the file’s consistent indentation and may fail formatting/lint checks; indent it to match the surrounding block (same level as the if (warningHint !== undefined) that follows).
| // #host-reference | |
| // #host-reference |
I have followed (at least) the PR section of the contributing guide.
https://github.com/mui/material-ui/blob/v7.x/scripts/buildLlmsDocs/index.ts#L71 too?
https://github.com/mui/material-ui/blob/v7.x/scripts/buildColorTypes.js#L6
https://github.com/mui/material-ui/blob/v7.x/packages/mui-utils/src/formatMuiErrorMessage/formatMuiErrorMessage.ts#L12
https://github.com/mui/material-ui/blob/v7.x/packages/mui-utils/src/elementTypeAcceptingRef/elementTypeAcceptingRef.ts#L56
https://github.com/mui/material-ui/blob/v7.x/packages/mui-system/src/ThemeProvider/ThemeProvider.d.ts#L23
https://github.com/mui/material-ui/blob/v7.x/packages/mui-system/src/cssVars/createCssVarsProvider.js#L282