-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
[autocomplete][multiple] Fixed Active option loses visual highlight after reopening the popup, but Enter still removes it #48177 #48241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
taralshah09
wants to merge
5
commits into
mui:master
from
taralshah09:fix/autocomplete-visual-highlight-reopen
+39
−1
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e425746
fix: restore visual highlight on Autocomplete reopen in multiple mode
taralshah09 2bc8e91
fix: restore visual highlight on Autocomplete reopen in multiple mode
taralshah09 0987daf
fix(Autocomplete): restore visual highlight on popup reopen in multip…
taralshah09 4ca8abb
fix(Autocomplete): add optional chaining and
taralshah09 d518378
Merge branch 'master' into fix/autocomplete-visual-highlight-reopen
taralshah09 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -507,6 +507,7 @@ function useAutocomplete(props) { | |
|
|
||
| if ( | ||
| highlightedIndexRef.current !== -1 && | ||
| previousProps.filteredOptions?.length > 0 && | ||
| !areArraysSame({ | ||
| array1: previousProps.filteredOptions, | ||
| array2: filteredOptions, | ||
|
|
@@ -538,7 +539,7 @@ function useAutocomplete(props) { | |
| // If it exists and the value and the inputValue haven't changed, just update its index, otherwise continue execution | ||
| const previousHighlightedOptionIndex = getPreviousHighlightedOptionIndex(); | ||
| if (previousHighlightedOptionIndex !== -1) { | ||
| highlightedIndexRef.current = previousHighlightedOptionIndex; | ||
| setHighlightedIndex({ index: previousHighlightedOptionIndex }); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This breaks scroll preservation Refer to these comments in the code below: |
||
| return; | ||
| } | ||
|
|
||
|
|
@@ -564,6 +565,7 @@ function useAutocomplete(props) { | |
| currentOption && | ||
| value.findIndex((val) => isOptionEqualToValue(currentOption, val)) !== -1 | ||
| ) { | ||
| setHighlightedIndex({ index: highlightedIndexRef.current }); | ||
| return; | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do?