Skip to content

[autocomplete] Remove tabIndex from options #48272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mj12albert wants to merge 1 commit into
base: master
Choose a base branch
from
+67 −2
Draft

[autocomplete] Remove tabIndex from options #48272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions packages/mui-material/src/Autocomplete/Autocomplete.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1408,6 +1408,72 @@ describe('<Autocomplete />', () => {
'aria-activedescendant',
);
});

// https://github.com/mui/material-ui/issues/31081
it('should not set tabIndex on option elements', async () => {
const { user } = render(
<Autocomplete
options={['one', 'two']}
renderInput={(params) => <TextField {...params} />}
/>,
);

await user.click(screen.getByRole('combobox'));
const options = screen.getAllByRole('option');
options.forEach((option) => {
expect(option).not.to.have.attribute('tabindex');
});
});

it('should still support keyboard navigation without tabIndex on options', async () => {
const { user } = render(
<Autocomplete
options={['one', 'two', 'three']}
renderInput={(params) => <TextField {...params} />}
/>,
);

await user.click(screen.getByRole('combobox'));

await user.keyboard('{ArrowDown}');
expect(screen.getByRole('combobox')).to.have.attribute(
'aria-activedescendant',
screen.getAllByRole('option')[0].id,
);

await user.keyboard('{ArrowDown}');
expect(screen.getByRole('combobox')).to.have.attribute(
'aria-activedescendant',
screen.getAllByRole('option')[1].id,
);

await user.keyboard('{Enter}');
expect(screen.getByRole('combobox').value).to.equal('two');
});

it('should skip disabled options during keyboard navigation without tabIndex', async () => {
const { user } = render(
<Autocomplete
options={['one', 'two', 'three']}
getOptionDisabled={(option) => option === 'two'}
renderInput={(params) => <TextField {...params} />}
/>,
);

await user.click(screen.getByRole('combobox'));

await user.keyboard('{ArrowDown}');
expect(screen.getByRole('combobox')).to.have.attribute(
'aria-activedescendant',
screen.getAllByRole('option')[0].id,
);

await user.keyboard('{ArrowDown}');
expect(screen.getByRole('combobox')).to.have.attribute(
'aria-activedescendant',
screen.getAllByRole('option')[2].id,
);
});
});

describe('when popup closed', () => {
Expand Down
3 changes: 1 addition & 2 deletions packages/mui-material/src/useAutocomplete/useAutocomplete.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ function useAutocomplete(props) {
? false
: !option || option.disabled || option.getAttribute('aria-disabled') === 'true';

if (option && option.hasAttribute('tabindex') && !nextFocusDisabled) {
if (option && option.getAttribute('role') === 'option' && !nextFocusDisabled) {
// The next option is available
return nextFocus;
}
Expand Down Expand Up @@ -1394,7 +1394,6 @@ function useAutocomplete(props) {

return {
key: getOptionKey?.(option) ?? getOptionLabel(option),
tabIndex: -1,
role: 'option',
id: `${id}-option-${index}`,
onMouseMove: handleOptionMouseMove,
Expand Down
Loading