Guard recursive Lua table bitstream reads#4798
Merged
qaisjp merged 2 commits intomultitheftauto:masterfrom Apr 12, 2026
Merged
Conversation
qaisjp
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The public source currently allows unbounded recursive LUA_TTABLE reads from the bitstream serializer. A crafted packet can drive recursive descent until deserialization fails from stack exhaustion or excessive recursion.
Current shipped binaries already enforce a 64-level limit in this path. This change brings the public source in line with that behavior so downstream forks and public builds do not keep the unbounded recursion path.
Testing