Conversation
DiegoDeGusem
left a comment
There was a problem hiding this comment.
Nice and very clean! Just one general comment. The altermagnets are not included on the website. They should be added in api.rst.
ilateur
left a comment
There was a problem hiding this comment.
I would still like to leverage the object-oriented approach by making the Altermagnet a child class of the Antiferromagnet. It has exactly the same functionality, but expanded. Even if physically these are totally different materials, the implementation of shared aspects is identical. Though I must admit, the amout of copy-pasting and function-tweaking is less bad than I expected.
Other than that, everything looks clean to me with some very nice tests.
ilateur
left a comment
There was a problem hiding this comment.
Make sure to resolve the merge conflicts as well
This pull request adds support for simulating d-wave altermagnets through a new
Altermagnetclass. The main difference withAntiferromagnetis the removal of the ferromagnetic exchange field in favor of an anisotropic field. In principle, the user is still able to take both fields into account, but that's their responsibility 😊.For the time being, only open boundaries and 2D magnets are supported in the anisotropic exchange.