Open
Conversation
also moved an image i had put in the wrong folder on my last pr oops, and also added some missing htmls to the spanish translation files (still untranslated though) also changed the spanish files css link paths so that they point to /docs/css/main.css instead of /docs/es/css/main.css, by changing them to ../css, i figured that might be easier than updating both css files when changing anything in them
Member
|
Would you like a bit more time to perfect it? |
Contributor
Author
|
Actually yeah give me a few days so I can fix those issues, thanks! |
in all articles the javascript approach i tried before caused there to be a small delay where the navbar would still show up on the left rather than on top, by changing from html embeds to inserting the sidebar with a js script the issue of having two html documents is solved and we can do responsive design in css which is the proper way to do it i think, it simplifies many things over what i was doing before
Contributor
Author
|
hey i think it's good to go now! ended up changing a lot of how it worked but i think it's much cleaner now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hello again! i saw the documentation didn't have responsive design when trying to use it on my phone so i thought i'd add a hamburger menu to it like the one in the homepage, i had to use some javascript for it though. It's still a little unfinished and there are some problems i hope to solve, such as the transition when switching articles, but it is usable i think.
the normal desktop view should be unchanged as far as i tested
I also linked the spanish docs css to the one in /docs/css/main.css instead of /docs/es/css/main.css, i thought it might be easier to edit just one instead of both
Btw, i apologize if this change is a little drastic, i feel like i should have asked beforehand. Regardless, I had fun doing it and learned some new things. That being said i wanted to try to add a search bar next if thats okay
here's a little preview of how it looks:
it's also in https://fiumals.github.io/muse-sequencer.github.io/docs/intro.html