Skip to content

fix: pass id with update notification preferences #355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meotch merged 1 commit into from
Feb 24, 2026
Merged

fix: pass id with update notification preferences #355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ls/src/main/java/com/mx/path/model/mdx/accessor/managed_card/ManagedCardBaseAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ public AccessorResponse<ManagedCard> update(String id, ManagedCard card) {
*/
@GatewayAPI
@API(description = "Update a managed card's notification preferences")
public AccessorResponse<NotificationPreferences> updateNotificationPreferences(NotificationPreferences notificationPreferences) {
public AccessorResponse<NotificationPreferences> updateNotificationPreferences(String id, NotificationPreferences notificationPreferences) {
throw new AccessorMethodNotImplementedException();
}
}
4 changes: 2 additions & 2 deletions mdx-web/src/main/java/com/mx/path/model/mdx/web/controller/ManagedCardsController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ public final ResponseEntity<ManagedCard> getCvv(@PathVariable("id") String id) t
}

@RequestMapping(value = "/users/{userId}/managed_cards/{id}/notification_preferences", method = RequestMethod.PUT, consumes = MDX_MEDIA)
public final ResponseEntity<?> updateNotificationPreferences(@RequestBody NotificationPreferences notificationPreferencesRequest) throws Exception {
AccessorResponse<NotificationPreferences> response = gateway().managedCards().updateNotificationPreferences(notificationPreferencesRequest);
public final ResponseEntity<?> updateNotificationPreferences(@PathVariable("id") String id, @RequestBody NotificationPreferences notificationPreferencesRequest) throws Exception {
AccessorResponse<NotificationPreferences> response = gateway().managedCards().updateNotificationPreferences(id, notificationPreferencesRequest);
return new ResponseEntity<>(response.getResult().wrapped(), createMultiMapForResponse(response.getHeaders()), HttpStatus.OK);
}
}
6 changes: 3 additions & 3 deletions ...eb/src/test/groovy/com/mx/path/model/mdx/web/controller/ManagedCardsControllerTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,13 @@ class ManagedCardsControllerTest extends Specification {
NotificationPreferences notificationPreferences = new NotificationPreferences().tap {
setAllowPushNotification(false)
}
doReturn(new AccessorResponse<NotificationPreferences>().withResult(notificationPreferences)).when(managedCardGateway).updateNotificationPreferences(notificationPreferences)
doReturn(new AccessorResponse<NotificationPreferences>().withResult(notificationPreferences)).when(managedCardGateway).updateNotificationPreferences("CARD-123", notificationPreferences)

when:
def response = subject.updateNotificationPreferences(notificationPreferences)
def response = subject.updateNotificationPreferences("CARD-123", notificationPreferences)

then:
verify(managedCardGateway).updateNotificationPreferences(notificationPreferences) || true
verify(managedCardGateway).updateNotificationPreferences("CARD-123", notificationPreferences) || true
response.body == notificationPreferences
HttpStatus.OK == response.statusCode
}
Expand Down