Improve transaction state detection logic#1144
Open
wanggang1111111 wants to merge 6 commits intomybatis:masterfrom
Open
Improve transaction state detection logic#1144wanggang1111111 wants to merge 6 commits intomybatis:masterfrom
wanggang1111111 wants to merge 6 commits intomybatis:masterfrom
Conversation
Member
|
@wanggang1111111 Please add back the line you deleted and remove the liekly 'vim' command you stuck in that java doc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When DataSourceUtils.getConnection(this.dataSource) creates a new connection,
this connection is automatically registered with Spring's TransactionSynchronizationManager.
Therefore, DataSourceUtils.isConnectionTransactional() returns true,
but in reality, this connection is newly created and should not be considered as a Spring-managed transactional connection.
Use TransactionSynchronizationManager.isActualTransactionActive() to check if there is an active Spring transaction.
Only when an active transaction exists should the connection be considered as a Spring-managed transactional connection.
This approach correctly distinguishes between newly created connections and genuine Spring-managed transactional connections.