Fix error handling for audio files that are shorter than 10 seconds#400
Open
derpoliuk wants to merge 1 commit intomyshell-ai:mainfrom
Open
Fix error handling for audio files that are shorter than 10 seconds#400derpoliuk wants to merge 1 commit intomyshell-ai:mainfrom
derpoliuk wants to merge 1 commit intomyshell-ai:mainfrom
Conversation
dosubot
bot
added
size:XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
split_audio_vadfunction was raising an assertion error for audio files shorter than 5 seconds due to rounding issues when calculating number of splits.Solution
Modified the function to handle short audio files as single segments when duration is less than
split_seconds(default 10s), while maintaining existing behavior for longer files.