Issues fix - Chore/migrate render html#12
Issues fix - Chore/migrate render html#12jsamr merged 4 commits intonative-html:chore/migrate-render-htmlfrom
Conversation
| translateX: 'block' | ||
| } as never; |
There was a problem hiding this comment.
I don't think as never is an acceptable tradeoff; I would rather not lose type safety here.
There was a problem hiding this comment.
I adjusted the type settings - and I'm already implementing the support for missing style attributes, I thought that it would be benefitial for me to learn how it is implemented
packages/render-html/package.json
Outdated
| "@jsamr/counter-style": "^2.0.2", | ||
| "@jsamr/react-native-li": "^2.3.1", | ||
| "@native-html/transient-render-engine": "workspace:*", | ||
| "@native-html/transient-render-engine": "^11.2.3", |
There was a problem hiding this comment.
This monorepo is meant to use Yarn workspaces; we cannot really avoid that. Having to manually handle versions would be cumbersome!
There was a problem hiding this comment.
Okay, I brought back previous implementation
5ZYSZ3K
force-pushed
the
chore/migrate-render-html
branch
from
94165d2 to
b5405f2
Compare
|
@jsamr I implemented it so that it supports props that are working (and should be supported I suppose), and ignores those that are either not working or should not be supported ( |
5ZYSZ3K
force-pushed
the
chore/migrate-render-html
branch
from
b5405f2 to
512c1b0
Compare
|
@5ZYSZ3K Thanks! Will review this weekend. Please press "re-request review" so that I get notified when you think it's ready. |
|
@jsamr How is this going? Is there anything I should start working on? I guess that I can also work on those typescript errors that are visible in workflows, but I don't know how urging they are |
jsamr
merged commit 45d1537
into
native-html:chore/migrate-render-html
2 participants
Fixed all of issues mentioned under the original PR
Also tested the migrated library in one of my private projects - was working fine