Adding CMakeLists.txt for cpp version#206
Open
micaah42 wants to merge 4 commits intonayuki:masterfrom
Open
Conversation
|
Support for MACOS and iOS: |
AlexisCompain
suggested changes
Apr 22, 2025
|
|
||
| set(CMAKE_CXX_STANDARD 11) | ||
| set(CMAKE_CXX_STANDARD_REQUIRED ON) | ||
| set(CMAKE_CXX_FLAGS "${CMAXE_CXX_FLAGS} -Wall -Werror") |
There was a problem hiding this comment.
This will only work for compiler that accepts this options (gcc/clang) but won't work for MSVC for example
I use this variant that is compatible with msvc too
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
add_compile_options(/W4 /EHsc)
elseif(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
add_compile_options(-Wall -Wextra)
endif()Note: additionally use add_compile_options instead of set for beter portability
There was a problem hiding this comment.
And please don't add -Werror. When I build this next year and my gcc18 suddenly comes with new warnings this will need patching. Instead do:
set(CMAKE_COMPILE_WARNING_AS_ERROR On)This was introduced in 3.24 and will just do nothing in older versions. This can then easily be disabled from the command line:
cmake --compile-no-warning-as-error …|
@nayuki: Have you seen this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello there,
I added a minimal
CMakeLists.txtto make it easier to include this repository in cmake driven projects.You can build a static library using:
Or include in other projects like this:
If you have any notes or want something fixed let me know :)