Skip to content

generalize zip on empty lists hint#1565

Open
jvoigtlaender wants to merge 4 commits intondmitchell:masterfrom
jvoigtlaender:zip-evaluate
Open

generalize zip on empty lists hint#1565
jvoigtlaender wants to merge 4 commits intondmitchell:masterfrom
jvoigtlaender:zip-evaluate

Conversation

@jvoigtlaender
Copy link
Copy Markdown
Contributor

Will the notEq x [] in the side condition work as intended, or is extra "escaping" of the list brackets necessary as in lhs and rhs?

@googleson78
Copy link
Copy Markdown
Contributor

What's notEq?

@jvoigtlaender
Copy link
Copy Markdown
Contributor Author

The hlint-internal side condition combinator that is already used at various other places in the same file.

@ndmitchell
Copy link
Copy Markdown
Owner

The notEq looks fine. However, you have also used isNonEmpty. As far as I can tell, that hasn't been in hlint for many years. Yes, there was a use of it. But no, it didn't do anything, so I've deleted it. Can you remove the isNonEmpty uses.

@jvoigtlaender
Copy link
Copy Markdown
Contributor Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants