fix: build explicit PyArrow schema in Neo4jGraphParquetFormatter#500
Open
matteomedioli wants to merge 3 commits intomainfrom
Open
fix: build explicit PyArrow schema in Neo4jGraphParquetFormatter#500matteomedioli wants to merge 3 commits intomainfrom
matteomedioli wants to merge 3 commits intomainfrom
Conversation
3582081 to
a0c03dc
Compare
…revent silent embedding column drops
a0c03dc to
05939ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pa.Table.from_pylist(rows)infers the Parquet schema from the first row it encounters. When the first node or relationship row has noembedding_properties, the embedding column is never created and all embedding values from subsequent rows are silently discarded. According to here:neo4j-graphrag-python/src/neo4j_graphrag/experimental/components/lexical_graph.py
Line 138 in 3d092f6
embedding_propertiesis empty dict{}.Minimal reproduction code:
The fix builds an explicit
pa.schemafrom the union of all keys across every row before callingfrom_pylist. Missing values are filled with null, and float-list columns (e.g. embeddings) are normalised tolist<float32>(default type for python float list) regardless of which row provides the first non-null sample.Type of Change
Complexity:
How Has This Been Tested?
Checklist
The following requirements should have been met (depending on the changes in the branch):