Workaround: #37 - Added base pathing in static js #39
Open
lc787 wants to merge 1 commit intonetbox-community:masterfrom
Open
Workaround: #37 - Added base pathing in static js #39lc787 wants to merge 1 commit intonetbox-community:masterfrom
lc787 wants to merge 1 commit intonetbox-community:masterfrom
Conversation
Author
|
There are a couple of |
|
I can get everything to work by also hacking the floorplan_view.html template, so now we can create floorplans, add racks, export SVG etc. One thing does not work. Klicking on an rack in an floorplan does not include the NETBOX_ROOT, thsu giving an 404. My Javascript knowledge is limited, and this is far down in fabric-js generated stuff, so if anyone knows where I need to hack things to get this working i would be very happy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workaround for #37
Okay, so the static files
edit.jsandutils.jsdon't really have a mechanism for relative path referencing. I've patched the scripts so it should be fine now. Unfortunately, I couldn't find a way to not hard-codenetbox_root, but at least I got it in one place only so the workaround isn't hard to apply. Mind you, I'm not a frontend developer, so I don't know how feasible it is to do this without a build process.